Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing bug where unsupported types in logs would not fail classification #688

Merged
merged 1 commit into from
Apr 16, 2018
Merged

fixing bug where unsupported types in logs would not fail classification #688

merged 1 commit into from
Apr 16, 2018

Conversation

ryandeivert
Copy link
Contributor

to: @jacknagz
cc: @airbnb/streamalert-maintainers
size: small
resolves #676

Background

See #676

Changes

  • Fixing bug during classification that would not fail if an invalid 'type' was defined in a log schema.
  • We should investigate how we could 'validate' this before it gets to this point in processing, since logs invalid log schemas are basically just burning processing time for every log.

@ryandeivert ryandeivert force-pushed the ryandeivert-fix-typing-bug branch from c5b8496 to df63ff3 Compare April 14, 2018 19:27
@coveralls
Copy link

coveralls commented Apr 14, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.001%) to 96.03% when pulling df63ff3 on ryandeivert-fix-typing-bug into cd144fc on master.

jacknagz
jacknagz approved these changes Apr 16, 2018
View reviewed changes
Copy link
Contributor

@jacknagz jacknagz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

@ryandeivert ryandeivert merged commit 69dee35 into master Apr 16, 2018
@ryandeivert ryandeivert deleted the ryandeivert-fix-typing-bug branch April 16, 2018 02:42
@ryandeivert ryandeivert added this to the 2.0.0 milestone Apr 23, 2018
@ryandeivert ryandeivert removed the apps label Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacknagz jacknagz jacknagz approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Classifier: Fail schemas with invalid types
3 participants
@ryandeivert @coveralls @jacknagz